RE: [PATCH 2/2] watchdog: rzg2l_wdt: Add rzv2m compatible string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

On 09 June 2022 11:11 Geert Uytterhoeven wrote:
> On Tue, Jun 7, 2022 at 3:59 PM Phil wrote:
> > The WDT on RZ/V2M devices is basically the same as RZ/G2L, with the
> > exception that the RZ/V2M has a single combined interrupt, whereas the
> > RZ/G2L has time out and error interrupts.
> 
> ... and that the RZ/V2M watchdog does not have the parity error
> handling.
> 
> > Signed-off-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx>
> > Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> 
> > --- a/drivers/watchdog/rzg2l_wdt.c
> > +++ b/drivers/watchdog/rzg2l_wdt.c
> > @@ -256,6 +256,7 @@ static int rzg2l_wdt_probe(struct platform_device
> *pdev)
> >
> >  static const struct of_device_id rzg2l_wdt_ids[] = {
> >         { .compatible = "renesas,rzg2l-wdt", },
> > +       { .compatible = "renesas,rzv2m-wdt", },
> 
> Hence this is not sufficient, as you need to prevent writing to the
> parity registers on RZ/V2M.

Oops, thanks for the review and noticing this.

Phil




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux