Re: [PATCH v2] dt-bindings: watchdog: toshiba,visconti-wdt: Update the common clock properties

[Guenter Roeck <linux@xxxxxxxxxxxx>]

On 5/20/22 02:00, Nobuhiro Iwamatsu wrote:
> The clock for this driver switched to the common clock controller driver.
> Therefore, update common clock properties for watchdog in the binding document.
> And this matched this example with the actual dts.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>
> ---
>   .../bindings/watchdog/toshiba,visconti-wdt.yaml     | 13 ++++---------
>   1 file changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> index 690e19ce4b87..52c0e0c022ea 100644
> --- a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> @@ -35,20 +35,15 @@ additionalProperties: false
>   
>   examples:
>     - |
> +    #include <dt-bindings/clock/toshiba,tmpv770x.h>
> +
>       soc {
>           #address-cells = <2>;
>           #size-cells = <2>;
>   
> -        wdt_clk: wdt-clk {
> -            compatible = "fixed-clock";
> -            clock-frequency = <150000000>;
> -            #clock-cells = <0>;
> -        };
> -
> -        watchdog@28330000 {
> +        wdt: watchdog@28330000 {
>               compatible = "toshiba,visconti-wdt";
>               reg = <0 0x28330000 0 0x1000>;
> -            clocks = <&wdt_clk>;
> -            timeout-sec = <20>;
> +            clocks = <&pismu TMPV770X_CLK_WDTCLK>;
>           };
>       };

wdt: isn't needed in the example, and I question if it
really improves the quality of the example to remove
timeout-sec.

Guenter