On Wed, May 04, 2022 at 04:25:59PM +0000, Hawkins, Nick wrote: > > On Tue, May 3, 2022 at 6:53 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > > > One bad deed tends to multiply. > > > > > > No, I didn't ask to pass a struct resource as platform data. > > > That would be no different to the current code. Resources can be added > > > to a platform device using platform_device_add_resources(), and the > > > platform driver can then use platform_get_resource() to use it. This > > > would make it independent of a "private" mechanism. > > > Unfortunately there is no resource type for __iomem tokens, only for physical addresses, so you'd end up having to do > ioremap() of the same address twice to map it into both the timer and the watchdog driver . Not the end of the world of course, but that doesn't seem much better than abusing the device private data. > > Hello Guenter, > > Given Arnd's feedback would you like me to proceed with this change still or do you have another recommendation? > Just leave it as is and add a note explaining why it is done that way. Guenter
