On 26/04/2022 15:21, Hawkins, Nick wrote: >> How is this h/w controlled? I'm guessing it's part of the timer? If so, you don't need this node. A single node can implement multiple functions. > > It is associated with the timer because of the shared register set. Based on feedback from Krzysztof I need to create a child node for gxp-timer. I therefore will remove this file and move gxp-wdt to the hpe,gxp-timer.yaml as a child node. I have impression my feedback was about mapping entire address space, not few registers of watchdog: https://lore.kernel.org/all/c6309ed8-6e74-67d3-304a-f5399d16cc37@xxxxxxxxxxxxx/ However later during talks it turned out that the address space is heavily shared. Nick, BTW, do you see my comments in the email I linked above? This v5 makes the same mistake. We talked about this already, so please make note of comments you receive and implement them. Best regards, Krzysztof
