-----Original Message----- From: Guenter Roeck [mailto:groeck7@xxxxxxxxx] On Behalf Of Guenter Roeck Sent: Wednesday, April 20, 2022 10:53 AM To: Hawkins, Nick <nick.hawkins@xxxxxxx>; Verdun, Jean-Marie <verdun@xxxxxxx>; Harders, Nick <nicholas.harders@xxxxxxx>; joel@xxxxxxxxx; arnd@xxxxxxxx Cc: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; linux-watchdog@xxxxxxxxxxxxxxx Subject: Re: [PATCH v4 03/11] drivers: wdt: Introduce HPE GXP SoC Watchdog On 4/20/22 08:01, nick.hawkins@xxxxxxx wrote: > > From: Nick Hawkins <nick.hawkins@xxxxxxx> > > > > Adding support for the HPE GXP Watchdog. It is new to the linux > > community and this along with several other patches is the first > > support for it. The GXP asic contains a full compliment of timers one > > of which is the watchdog timer. The watchdog timer is 16 bit and has > > 10ms resolution. The watchdog is now > Drop "now". I have corrected this. > > created as a child device of timer since the same register range is > > used. This was done due to changes requested with the device tree. > > > Drop last sentence; it is part of the change log and should stay there. I have corrected this. > > --- > Changes made in v3 and v4 are missing. Fixed, I will fix this on the rest of the patches on this set. > > +config GXP_WATCHDOG > > + tristate "HPE GXP watchdog support" > > + depends on ARCH_HPE_GXP > > + select WATCHDOG_CORE > > + help > > + Say Y here to include support for the watchdog timer > > + in HPE GXP SoCs. > > + > Add something like: > To compile this driver as a module, choose M here: the > module will be calledgxp_wdt. This has been changed. I will look through the rest of the other Kconfigs to make sure this statement is there. Thanks for the feedback, -Nick Hawkins
