Re: [PATCH v5 3/9] i2c: piix4: Move port I/O region request/release code into functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Wolfram Sang <wsa@xxxxxxxxxx>
Subject: Re: [PATCH v5 3/9] i2c: piix4: Move port I/O region request/release code into functions
From: Jean Delvare <jdelvare@xxxxxxx>
Date: Tue, 15 Feb 2022 09:37:42 +0100
Cc: Terry Bowman <terry.bowman@xxxxxxx>, linux@xxxxxxxxxxxx, linux-watchdog@xxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, andy.shevchenko@xxxxxxxxx, rafael.j.wysocki@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, wim@xxxxxxxxxxxxxxxxxx, rrichter@xxxxxxx, thomas.lendacky@xxxxxxx, sudheesh.mavila@xxxxxxx, Nehal-bakulchandra.Shah@xxxxxxx, Basavaraj.Natikar@xxxxxxx, Shyam-sundar.S-k@xxxxxxx, Mario.Limonciello@xxxxxxx
In-reply-to: <YgZ12hCMUlqtLKD3@kunai>
Organization: SUSE Linux
References: <20220209172717.178813-1-terry.bowman@amd.com> <20220209172717.178813-4-terry.bowman@amd.com> <20220211105322.180ad89d@endymion.delvare> <YgZ12hCMUlqtLKD3@kunai>

On Fri, 11 Feb 2022 15:42:34 +0100, Wolfram Sang wrote:
> > > +		if (retval)  
> > 
> > Missing curly brace here, breaks the build.  
> 
> Bummer, need to check why this wasn't found by my build-testing.

Maybe you build-tested the series as a whole but not individual
patches? The series did build fine, as the missing curly brace was
added back in a later patch.

-- 
Jean Delvare
SUSE L3 Support

Follow-Ups:
- Re: [PATCH v5 3/9] i2c: piix4: Move port I/O region request/release code into functions
  - From: Wolfram Sang

References:
- [PATCH v5 0/9] i2c: piix4: Replace cd6h/cd7h port I/O accesses with MMIO accesses
  - From: Terry Bowman
- [PATCH v5 3/9] i2c: piix4: Move port I/O region request/release code into functions
  - From: Terry Bowman
- Re: [PATCH v5 3/9] i2c: piix4: Move port I/O region request/release code into functions
  - From: Jean Delvare
- Re: [PATCH v5 3/9] i2c: piix4: Move port I/O region request/release code into functions
  - From: Wolfram Sang

Prev by Date: [PATCH] dt-bindings: watchdog: imx7ulp-wdt: Add imx93 compatible string
Next by Date: Re: [PATCH v5 3/9] i2c: piix4: Move port I/O region request/release code into functions
Previous by thread: Re: [PATCH v5 3/9] i2c: piix4: Move port I/O region request/release code into functions
Next by thread: Re: [PATCH v5 3/9] i2c: piix4: Move port I/O region request/release code into functions
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]