On Tue, 18 Jan 2022 14:22:31 -0600, Terry Bowman wrote: > Refactor driver's timer initialization into new function. This is needed > inorder to support adding new device layouts while using common timer > initialization. > > Co-developed-by: Robert Richter <rrichter@xxxxxxx> > Signed-off-by: Robert Richter <rrichter@xxxxxxx> > Signed-off-by: Terry Bowman <terry.bowman@xxxxxxx> > To: Guenter Roeck <linux@xxxxxxxxxxxx> > To: linux-watchdog@xxxxxxxxxxxxxxx > To: Jean Delvare <jdelvare@xxxxxxxx> > To: linux-i2c@xxxxxxxxxxxxxxx > To: Wolfram Sang <wsa@xxxxxxxxxx> > To: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> > To: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx > Cc: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx> > Cc: Robert Richter <rrichter@xxxxxxx> > Cc: Thomas Lendacky <thomas.lendacky@xxxxxxx> > --- > drivers/watchdog/sp5100_tco.c | 65 +++++++++++++++++++---------------- > 1 file changed, 36 insertions(+), 29 deletions(-) > (...) Except for the issues already mentioned by Andy, looks good to me. Reviewed-by: Jean Delvare <jdelvare@xxxxxxx> -- Jean Delvare SUSE L3 Support
