Re: [PATCH v3 8/9] i2c: piix4: Add EFCH MMIO support for SMBus port select

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Terry Bowman <Terry.Bowman@xxxxxxx>
Subject: Re: [PATCH v3 8/9] i2c: piix4: Add EFCH MMIO support for SMBus port select
From: Wolfram Sang <wsa@xxxxxxxxxx>
Date: Fri, 21 Jan 2022 22:07:57 +0100
Cc: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>, linux-watchdog@xxxxxxxxxxxxxxx, Jean Delvare <jdelvare@xxxxxxxx>, linux-i2c <linux-i2c@xxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>, Robert Richter <rrichter@xxxxxxx>, Tom Lendacky <thomas.lendacky@xxxxxxx>, sudheesh.mavila@xxxxxxx, "Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@xxxxxxx>, Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx>, Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>, Mario Limonciello <Mario.Limonciello@xxxxxxx>
In-reply-to: <846b8323-2ebb-90c1-d1df-b12a303206f3@amd.com>
Mail-followup-to: Wolfram Sang <wsa@xxxxxxxxxx>, Terry Bowman <Terry.Bowman@xxxxxxx>, Andy Shevchenko <andy.shevchenko@xxxxxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>, linux-watchdog@xxxxxxxxxxxxxxx, Jean Delvare <jdelvare@xxxxxxxx>, linux-i2c <linux-i2c@xxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rafael.j.wysocki@xxxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>, Robert Richter <rrichter@xxxxxxx>, Tom Lendacky <thomas.lendacky@xxxxxxx>, sudheesh.mavila@xxxxxxx, "Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@xxxxxxx>, Basavaraj Natikar <Basavaraj.Natikar@xxxxxxx>, Shyam Sundar S K <Shyam-sundar.S-k@xxxxxxx>, Mario Limonciello <Mario.Limonciello@xxxxxxx>
References: <20220119230626.31560-1-terry.bowman@amd.com> <20220119230626.31560-9-terry.bowman@amd.com> <CAHp75VcGmmRpRD99tFHd7WOPs6uyz3uWuTEoc=G+VmbPYAUvuA@mail.gmail.com> <846b8323-2ebb-90c1-d1df-b12a303206f3@amd.com>

> Looking at this closer I find the added line separates the closing 
> function brace from the next function's comment header. Are you sure I 
> need to remove this line?

I agree you can leave it.

Attachment: signature.asc
Description: PGP signature

References:
- [PATCH v3 0/9] i2c: piix4: Replace cd6h/cd7h port I/O accesses with MMIO accesses
  - From: Terry Bowman
- [PATCH v3 8/9] i2c: piix4: Add EFCH MMIO support for SMBus port select
  - From: Terry Bowman
- Re: [PATCH v3 8/9] i2c: piix4: Add EFCH MMIO support for SMBus port select
  - From: Andy Shevchenko
- Re: [PATCH v3 8/9] i2c: piix4: Add EFCH MMIO support for SMBus port select
  - From: Terry Bowman

Prev by Date: Re: [PATCH v3 8/9] i2c: piix4: Add EFCH MMIO support for SMBus port select
Next by Date: Re: [PATCH] dt-bindings: watchdog: fsl-imx7ulp-wdt: Fix assigned-clock-parents
Previous by thread: Re: [PATCH v3 8/9] i2c: piix4: Add EFCH MMIO support for SMBus port select
Next by thread: Re: [PATCH v3 0/9] i2c: piix4: Replace cd6h/cd7h port I/O accesses with MMIO accesses
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]