On 29 November 2021 12:12, Andrej Picej wrote: > > I'm a little concerned about forcing this change in the driver. There may be > > platforms which don't want the PMIC to perform a full reset through OTP re- > read > > and if we hard code this change then that's impacting those platforms. If we > > want/need this then I think it should probably be a DT binding for da9061/2 > > which then indicates the behaviour we want. > > Ok, I see the impact this might have on the platforms that are relying > on the current default setting. I will start on the DT binding > implementation and submit a new patch. Thanks. Probably the safest route. > > > > > NRES_MODE bit also plays a part here as it controls whether or not the nRESET > > line state is changed as part of the power-down/up process. I'm assuming for > > your setup this bit is 0? > > > We leave NRES_MODE as it is, 0 by default I guess? So do you want a > separate dt binding for NRES_MODE? I think the setting very much depends on the customers OTP config selection. For now we can leave this option. Just wanted to highlight it.
