On Tue, Nov 9, 2021 at 11:30 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > On 11/8/21 11:59 PM, Art Nikpal wrote: > > hi Guenter Roeck > > why still not merged to upstream ? > > > > I had asked you to provide an updated description, without the "personal > opinion" part which does not belong into a commit log. The other two > patches wait for Wim to send them upstream. > ok i have send this patch with new description again > Guenter > > > > On Fri, Jul 30, 2021 at 12:14 PM Artem Lapkin <email2tema@xxxxxxxxx> wrote: > >> > >> Remove watchdog_stop_on_reboot() > >> > >> Meson platform still have some hardware drivers problems for some > >> configurations which can freeze device on shutdown/reboot stage and i > >> think better to have reboot warranty by default. > >> > >> I feel that it is important to keep the watchdog running during the > >> reboot sequence, in the event that an abnormal driver freezes the reboot > >> process. > >> > >> This is my personal opinion and I hope the driver authors will agree > >> with my proposal, or just ignore this commit if not. > >> > >> https://lore.kernel.org/linux-watchdog/20210729072308.1908904-1-art@xxxxxxxxxx/T/#t > >> > >> Signed-off-by: Artem Lapkin <art@xxxxxxxxxx> > >> --- > >> drivers/watchdog/meson_gxbb_wdt.c | 1 - > >> 1 file changed, 1 deletion(-) > >> > >> diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c > >> index 945f5e65db57..d3c9e2f6e63b 100644 > >> --- a/drivers/watchdog/meson_gxbb_wdt.c > >> +++ b/drivers/watchdog/meson_gxbb_wdt.c > >> @@ -198,7 +198,6 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) > >> > >> meson_gxbb_wdt_set_timeout(&data->wdt_dev, data->wdt_dev.timeout); > >> > >> - watchdog_stop_on_reboot(&data->wdt_dev); > >> return devm_watchdog_register_device(dev, &data->wdt_dev); > >> } > >> > >> -- > >> 2.25.1 > >> >
