On 27.10.2021 19:39, Florian Fainelli wrote:
On 10/27/21 10:31 AM, Guenter Roeck wrote:
On Wed, Oct 27, 2021 at 02:31:35PM +0200, Rafał Miłecki wrote:
From: Rafał Miłecki <rafal@xxxxxxxxxx>
This fixes:
drivers/watchdog/bcm63xx_wdt.c: In function 'bcm63xx_wdt_ioctl':
drivers/watchdog/bcm63xx_wdt.c:208:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>
[reluctantly]
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
... because the driver should really be converted to use the watchdog subsystem,
by someone with the necessary hardware to test it.
The driver should ideally be removed and we should use bcm7038_wdt.c
moving forward. Rafal, is this something you can try on 4908?
I wasn't sure if I should proceed with bcm63xx_wdt.c or bcm7038_wdt.c so
I chose 63xx. Possibly a bad decision, I'm not sure.
I've already bcm63xx_wdt.c changes developed locally to support BCM4908.
I just need to add Documentation/dt-bindings/ part. I'll do that
tomorrow. Then you can let me know if that's acceptable or should I
refactor my changes.
