[PATCH v5 0/7] watchdog: f71808e_wdt: migrate to new kernel API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This series migrates the driver to the new kernel watchdog API and
then to the driver model.

I tested it on a f81866.

v4 -> v5:
  - Collect Guenter's Reviewed-by's
  - remove superfluous max_timeout global in existing code (Guenter)
  - constify static array in existing code (Guenter)
  - fix wrong handling of start_withtimeout (Guenter)
  - add local variable dev = &pdev->dev

v3 -> v4:
  https://lore.kernel.org/linux-watchdog/cover.c711be1db54f4e07c0153266dd1a831e92e3d49d.1626948810.git-series.a.fatoum@xxxxxxxxxxxxxx/
  - Prepend fix for wrong timeout report (Guenter)
  - Remove WDOG_HW_RUNNING setting in start as the watchdog can
    be stopped (Guenter)
  - Dynamically allocate watchdog driver data (Guenter)

v3 -> RESEND:
  https://lore.kernel.org/linux-watchdog/cover.dedd9f1159389b0a438076ef5e5a46aded186463.1612457906.git-series.a.fatoum@xxxxxxxxxxxxxx/#t
  Didn't generate any feedback over 2 months. Resending for exposure.

v2 -> v3:
  https://lore.kernel.org/linux-watchdog/20201020062112.6762-1-a.fatoum@xxxxxxxxxxxxxx/
  - factored out identifier renaming again for easier review
  - reordered commits
  - removed refactoring that can go in later. Focusing now on kernel watchdog
    API and platform device/driver migration
  - removed platform_device_id and changed code to match by name

v1 -> v2:
  https://lore.kernel.org/linux-watchdog/20200611191750.28096-1-a.fatoum@xxxxxxxxxxxxxx/
  - reworked to platform device/driver pair (Guenter)
  - squashed identifier renaming into the patches that touch
    the respective lines anyway
  - fixed checkpatch.pl nitpicks (Guenter)
  - fixed locally used variable declared without static (0-day)
  - fixed unneded line break due to old line limit (Guenter)
  - renamed struct fintek_wdog_data to struct fintek_wdt

Ahmad Fatoum (7):
  watchdog: f71808e_wdt: fix inaccurate report in WDIOC_GETTIMEOUT
  watchdog: f71808e_wdt: remove superfluous global
  watchdog: f71808e_wdt: constify static array
  watchdog: f71808e_wdt: rename variant-independent identifiers appropriately
  watchdog: f71808e_wdt: migrate to new kernel watchdog API
  watchdog: f71808e_wdt: refactor to platform device/driver pair
  watchdog: f71808e_wdt: dynamically allocate watchdog driver data

 drivers/watchdog/Kconfig       |   1 +-
 drivers/watchdog/f71808e_wdt.c | 615 +++++++++++-----------------------
 2 files changed, 201 insertions(+), 415 deletions(-)

base-commit: 36a21d51725af2ce0700c6ebcb6b9594aac658a6
-- 
git-series 0.9.1



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux