On 26.07.21 14:01, Andy Shevchenko wrote:
> On Mon, Jul 26, 2021 at 2:46 PM Jan Kiszka <jan.kiszka@xxxxxxxxxxx> wrote:
>>
>> From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
>>
>> Obviously, the test needs to run against the register content, not its
>> address.
>>
>> Fixes: cb011044e34c ("watchdog: iTCO_wdt: Account for rebooting on second timeout")
>> Reported-by: Mantas Mikulėnas <grawity@xxxxxxxxx>
>
>> Signed-off-by: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
>
> Missed SoB of the submitter (hint: configure your Git to make sure
> that submitter and author are the same in terms of name-email).
The signed off is there. Not sure what you are referring to.
>
> ...
>
>> if (p->smi_res &&
>> - (SMI_EN(p) & (TCO_EN | GBL_SMI_EN)) != (TCO_EN | GBL_SMI_EN))
>> + (inl(SMI_EN(p)) & (TCO_EN | GBL_SMI_EN)) != (TCO_EN | GBL_SMI_EN))
>> tmrval /= 2;
>
> There are so many parentheses, perhaps
>
> #define TCO_GBL_SMI_EN (TCO_EN | GBL_SMI_EN)
> ...
> if (p->smi_res &&
> (inl(SMI_EN(p)) & TCO_GBL_SMI_EN) != TCO_GBL_SMI_EN)
> tmrval /= 2;
>
> ?
>
Let's focus on the regression fix (and you could have mentioned that on
the original patch already).
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
