Re: [PATCH v2 1/3] clk: add devm_clk_prepare_enable() helper

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Stephen Boyd <sboyd@xxxxxxxxxx>
Subject: Re: [PATCH v2 1/3] clk: add devm_clk_prepare_enable() helper
From: Guenter Roeck <linux@xxxxxxxxxxxx>
Date: Mon, 8 Mar 2021 21:28:29 -0800
Cc: Rob Herring <robh+dt@xxxxxxxxxx>, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-clk@xxxxxxxxxxxxxxx, linux-watchdog@xxxxxxxxxxxxxxx
In-reply-to: <20210304221247.488173-2-linux@rasmusvillemoes.dk>
References: <20210226141411.2517368-1-linux@rasmusvillemoes.dk> <20210304221247.488173-1-linux@rasmusvillemoes.dk> <20210304221247.488173-2-linux@rasmusvillemoes.dk>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 3/4/21 2:12 PM, Rasmus Villemoes wrote:
> Add a managed wrapper for clk_prepare_enable().
> 
> Signed-off-by: Rasmus Villemoes <linux@xxxxxxxxxxxxxxxxxx>

That has been tried several times, including by yours truly,
and has always been rejected.

Just use devm_add_action_or_reset() like many other watchdog
drivers.

Guenter

Follow-Ups:
- Re: [PATCH v2 1/3] clk: add devm_clk_prepare_enable() helper
  - From: Dmitry Torokhov

References:
- [PATCH v2 0/3] add "delay" clock support to gpio_wdt
  - From: Rasmus Villemoes
- [PATCH v2 1/3] clk: add devm_clk_prepare_enable() helper
  - From: Rasmus Villemoes

Prev by Date: Re: [PATCH v1 1/2] watchdog: add global watchdog kernel module parameters structure
Next by Date: Re: [PATCH v2 0/3] add "delay" clock support to gpio_wdt
Previous by thread: [PATCH v2 1/3] clk: add devm_clk_prepare_enable() helper
Next by thread: Re: [PATCH v2 1/3] clk: add devm_clk_prepare_enable() helper
Index(es):
- Date
- Thread

[Index of Archives] [Linux ARM Kernel] [Linux ARM] [Linux Omap] [Fedora ARM] [IETF Annouce] [Security] [Bugtraq] [Linux] [Linux OMAP] [Linux MIPS] [eCos] [Asterisk Internet PBX] [Linux API]