On Thu, Dec 3, 2020 at 2:34 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote: > > From: Arnd Bergmann <arnd@xxxxxxxx> > > clang produces a build failure in configurations without COMMON_CLK > when a timeout calculation goes wrong: > > arm-linux-gnueabi-ld: drivers/watchdog/coh901327_wdt.o: in function `coh901327_enable': > coh901327_wdt.c:(.text+0x50): undefined reference to `__bad_udelay' Isn't a linkage failure against __bad_udelay supposed to be interpreted as a value too large being passed to udelay()? IIRC, this was an issue for someone building an Apple touchpad driver with Clang at -O3...you sent a fix for that: https://github.com/ClangBuiltLinux/linux/issues/678, https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git/commit/?id=fff2d0f701e6753591609739f8ab9be1c8e80ebb. > > Add a Kconfig dependency to only do build testing when COMMON_CLK > is enabled. > > Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible") > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > --- > drivers/watchdog/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig > index 8bdbd125821b..32fa6de7b820 100644 > --- a/drivers/watchdog/Kconfig > +++ b/drivers/watchdog/Kconfig > @@ -631,7 +631,7 @@ config SUNXI_WATCHDOG > > config COH901327_WATCHDOG > bool "ST-Ericsson COH 901 327 watchdog" > - depends on ARCH_U300 || (ARM && COMPILE_TEST) > + depends on ARCH_U300 || (ARM && COMMON_CLK && COMPILE_TEST) > default y if MACH_U300 > select WATCHDOG_CORE > help > -- > 2.27.0 > -- Thanks, ~Nick Desaulniers
