On Sun, Jun 28, 2020 at 07:54:20AM -0700, Guenter Roeck wrote: > On Sat, Jun 20, 2020 at 12:33:46PM -0500, minyard@xxxxxxx wrote: > > From: Corey Minyard <cminyard@xxxxxxxxxx> > > > > If the WDIOF_MSECTIMER is set, then all the timeouts in the watchdog > > structure are expected to be in milliseconds. Add the flag and the > > various conversions. This should have no effect on existing drivers. > > > > I have decided to go another route: Instead of using a WDIOF_MSECTIMER > flag, provide new callback functions. That increases structure sizes, > but ultimately I think it is cleaner. > > I implemented a prototype, but didn't have a chance to test it yet. Oh, ok. I was looking at going through all the existing drivers and changing the direct references to timeout and pretimeout to use accessor functions. That what what I thought you were hinting at, and I thought that was a good plan. My original idea was to provide the ability, change everything over, then remove the messy cruft from the core driver. If you want to send something, I can try it out. -corey > > Guenter
