On Fri, Apr 24, 2020 at 8:17 AM Julius Werner <jwerner@xxxxxxxxxxxx> wrote: > > > + err = of_property_read_u32(pdev->dev.of_node, "arm,smc-id", > > + &smc_func_id); > > + if (err < 0) > > + return err; > > + watchdog_set_drvdata(wdd, (void *)(uintptr_t)smc_func_id); > > Your device tree binding says there's a default and this is optional. > I think you need to change the code so that that's actually true. I think I have misunderstood the device tree json-schema spec. My intention was for the device tree to fill in a default value in the dtb for arm,smc-id if it was omitted in the dts. But now I see that does not seem to happen, I cannot really find any documentation of `default`, so I will just put a documentation string in instead and force the default in the driver.
