> Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU > case > > On Mon, Mar 16, 2020 at 02:51:47AM +0000, Peng Fan wrote: > > Hi Shawn, > > > > > Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for > > > !CONFIG_IMX_SCU case > > > > > > On Mon, Mar 09, 2020 at 01:40:18PM +0000, Peng Fan wrote: > > > > > Subject: [PATCH V3 1/7] firmware: imx: Add stubs for > > > > > !CONFIG_IMX_SCU case > > > > > > > > I have one patch pending reviewing. > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2F > > > > patc > > > > > > > > hwork.kernel.org%2Fpatch%2F11395247%2F&data=02%7C01%7Cpeng.f > > > an%40n > > > > > > > > xp.com%7C995815002e2b490791e008d7c9445133%7C686ea1d3bc2b4c6fa9 > > > 2cd99c5c > > > > > > > > 301635%7C0%7C0%7C637199167574579419&sdata=RM4Mtwl8LZ3ft9 > > > 3uL3FQPcHT > > > > 9lPHSqBOgugozkcLvag%3D&reserved=0 > > > > > > I dropped that patch from my queue and picked patch #2 from this > > > series as the favor. > > > > I think dropping that patch might cause Linux-next build fail as > > previously showed, because IMX_SCU_SOC depends on COMPILE_TEST. If > you > > drop that patch, also need to drop COMPILE_TEST from IMX_SCU_SOC. > > > > ld: drivers/soc/imx/soc-imx-scu.o: in function `.imx_scu_soc_probe': > > soc-imx-scu.c:(.text.imx_scu_soc_probe+0x44): undefined reference to > > `.imx_scu_get_handle' > > ld: soc-imx-scu.c:(.text.imx_scu_soc_probe+0x134): undefined > > reference to `.imx_scu_call_rpc' > > ld: soc-imx-scu.c:(.text.imx_scu_soc_probe+0x20c): undefined > > reference to `.imx_scu_call_rpc' > > > > Caused by commit > > > > 68c189e3a93c ("soc: imx: increase build coverage for imx8m soc > > driver") > > > > What do you prefer? I personally think dummy functions would be good. > > I would rather drop COMPILE_TEST from IMX_SCU_SOC. Could you send a > patch for that shortly? Just sent out. One more thing, I think all drivers depends on IMX_SCU should not have COMPILE_TEST if we plan not to add dummy functions. I see you picked up Anson's patch in imx/drivers branch, please check more. Thanks, Peng. > > Shawn
