On Mon, Mar 09, 2020 at 06:30:54PM +0100, Alexandre Belloni wrote: > On 09/03/2020 10:10:12-0700, Guenter Roeck wrote: > > On Mon, Mar 09, 2020 at 05:47:05PM +0100, Alexandre Belloni wrote: > > > On 09/03/2020 06:27:06-0700, Guenter Roeck wrote: > > > > On 3/9/20 4:06 AM, Alexandre Belloni wrote: > > > > > On 09/03/2020 08:38:14+0800, Anson Huang wrote: > > > > >> Add stubs for those i.MX SCU APIs to make those modules depending > > > > >> on IMX_SCU can pass build when COMPILE_TEST is enabled. > > > > >> > > > > >> Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > > > > >> --- > > > > >> Changes since V2: > > > > >> - return error for stubs. > > > > > > > > > > I'm not sure why you are sending v3 with the stubs as we determined that > > > > > 2/7 is enough to compile all the drivers with COMPILE_TEST. > > > > > > > > > > > > > > 2/7 alone is not sufficient. With only 2/7, one can explicitly configure > > > > IMX_SCU=n, COMPILE_TEST=y, and get lots of compile failures. Granted, > > > > one should not do that, but 0day does (I don't know if that is the result > > > > of RANDCONFIG), and I am not looking forward having to deal with the > > > > fallout. > > > > > > > > > > How would that be possible if the drivers all depend on IMX_SCU? > > > > > That dependency is being changed to IMX_SCU || COMPILE_TEST > > as part of the series. > > > > Yes, my point is that those patches should not be applied at all, only > 2/7. Ah, now I get it. Sorry, I missed that part. You are correct, that would be sufficient, and I would very much prefer that approach. Thanks, Guenter
