Hi, Guenter > Subject: Re: [PATCH 3/3] watchdog: imx2_wdt: Remove unused include of > init.h > > On Fri, Feb 21, 2020 at 10:00:30AM +0800, Anson Huang wrote: > > There is nothing in use from init.h, remove it. > > > > NACK, sorry; this driver uses __init and __exit_p. Ah, yes, just notice them. But I don't understand why the .probe callback needs __init and .remove callback needs __exit_p? Should they need to be removed? Thanks, Anson > Guenter > > > Signed-off-by: Anson Huang <Anson.Huang@xxxxxxx> > > --- > > drivers/watchdog/imx2_wdt.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c > > index f8d58bf..ce28e40 100644 > > --- a/drivers/watchdog/imx2_wdt.c > > +++ b/drivers/watchdog/imx2_wdt.c > > @@ -20,7 +20,6 @@ > > > > #include <linux/clk.h> > > #include <linux/delay.h> > > -#include <linux/init.h> > > #include <linux/interrupt.h> > > #include <linux/io.h> > > #include <linux/kernel.h>
