On 2/8/20 6:01 AM, Marco Felsch wrote:
Hi, On 20-02-08 05:08, Guenter Roeck wrote:Since commit 057b52b4b3d58 ("watchdog: da9062: make restart handler atomic safe"), the driver calls i2c functions directly. It now therefore depends on I2C. This is a hard dependency which overrides COMPILE_TEST.I just wondered why it doesn't complain if no regmap support is on and surprise it provides stubs ^^ Is it worth to add i2c stubs too?
I'd rather not go there. In practice it doesn't make much of a difference - it just ensures that COMPILE_TEST can run on architectures which don't support I2C. I think 0day only finds it because they select COMPILE_TEST and then selectively disable I2C (and maybe other configuration options) to catch problems like this. Guenter
