On Thu, Feb 6, 2020 at 3:56 PM Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> wrote: > > On Thu, Feb 06, 2020 at 03:45:32PM +0100, Jean Delvare wrote: > > Hi Mika, > > > > On Wed, 5 Feb 2020 18:38:31 +0200, Mika Westerberg wrote: > > > On Wed, Feb 05, 2020 at 08:30:48AM -0800, Guenter Roeck wrote: > > > > On Wed, Feb 05, 2020 at 05:24:35PM +0200, Mika Westerberg wrote: > > > > > You should be able to revert to iTCO_wdt by simply disabling > > > > > CONFIG_WDAT_WDT from .config. Then acpi_has_watchdog() returns false > > > > > which means that iTCO_wdt is used instead. > > > > > > > > That may not be possible in a generic distribution. > > > > > > Right, they would need to build their own kernel. Currently there is no > > > way to do that without changing .config. > > > > OK, that's pretty much what I was compl^Wworried about ;-) Would you > > consider applying something like the following patch? > > Yes, I think the patch makes sense. > > Rafael, I guess you will take this since it is touching ACPI? Yes, I will. > > From: Jean Delvare <jdelvare@xxxxxxx> > > Subject: ACPI / watchdog: Allow disabling WDAT at boot > > > > In case the WDAT interface is broken, give the user the option to > > ignore it to let a native driver bind to the watchdog device instead. > > > > Signed-off-by: Jean Delvare <jdelvare@xxxxxxx> > > Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > > Cc: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> > > Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> Thanks!