On 07.10.2019 16:14, Alexandre Belloni wrote: > > On 07/10/2019 05:36:38-0700, Guenter Roeck wrote: >> On 10/7/19 12:58 AM, Eugen.Hristev@xxxxxxxxxxxxx wrote: >> [ ... ] >>> Hello Guenter, >>> >>> Thank you for the feedback. >>> After reviewing this, can you please guide me towards one of the >>> possible two directions: merge this driver with sama5d4_wdt , and have a >>> single driver with support for both hardware blocks; or, have this >>> driver separately , as in this patch series? >>> >> >> I noticed the similarities. I don't know if it makes sense to reconcile >> the two drivers; it seems to me the new chip uses the same basic core with >> enhancements. In general, I prefer a single driver, but only if the result >> doesn't end up being an if/else mess. Ultimately, it is really your call >> to make. >> > > Most if not all your comments were already addressed in the other > driver. The main difference in the register interface is the location of > the counter that only really affects sama5d4_wdt_set_timeout and that > could be abstracted away by using a different struct watchdog_ops. > Interrupt enabling is also done differently, I don't think it has a huge > impact. > Thank you Guenter and Alexandre, I will start working on a v2 with a merged driver. Thanks again, Eugen
