On 10/7/19 3:49 AM, Bruno Thomsen wrote:
Hi Guenter & Martin
Den søn. 6. okt. 2019 kl. 18.19 skrev Guenter Roeck <linux@xxxxxxxxxxxx>:
This should not be decided on driver level. The intended means to
enforce
an initial timeout would be to set CONFIG_WATCHDOG_OPEN_TIMEOUT, or to
use
the open_timeout kernel parameter.
That, and WATCHDOG_HANDLE_BOOT_ENABLED
To clarify: If WATCHDOG_HANDLE_BOOT_ENABLED is disabled, the watchdog core
does not ping the watchdog on its own, and Bruno's argument does not apply
in the first place.
Thanks for clarifying.
When reading the WDOG_HW_RUNNING bit description in kernel api [1]
documentation around line 247 you don't get the impression that the behavior
can be modified by 2 Kconfig options and 1 runtime option. Maybe add an
additional note?
That is probably because the two configuration options were added later
and the documentation was not updated. Patches welcome.
Guenter
I am overall okay with the change, but I have a few extra comments.
If the dev_err message is kept there is a typo in register name: wd_val.
The variable name wdd_timeout is a bit misleading as the register does not
contain the initial timeout value but a countdown value, ex. wdd_value.
Bruno
[1] Documentation/watchdog/watchdog-kernel-api.rst
