Hi, regarding the test for the WATCHDOG_NOWAYOUT patch: ``` Tested-by: Razvan Becheriu <razvan.becheriu@xxxxxxxxx> The patch works. By configuring the CONFIG_WATCHDOG_NOWAYOUT in the kernel and stopping the watchdog.service, the board reboots. Previously, the watchdog.service was able to disable the watchdog counter, and no reboot was performed. ``` Thank you, Razvan On Tue, Oct 1, 2019 at 10:06 PM razvan becheriu <razvan.becheriu@xxxxxxxxx> wrote: > > Hi, > > regarding the test for the WATCHDOG_NOWAYOUT patch: > > ... > Tested-by: Razvan Becheriu <razvan.becheriu@xxxxxxxxx> > The patch works. > By configuring the CONFIG_WATCHDOG_NOWAYOUT in the kernel and stopping the watchdog.service, the board reboots. > Previously, the watchdog.service was able to disable the watchdog counter, and no reboot was performed. > ... > > Thank you, > Razvan > > On Tue, Sep 24, 2019 at 6:13 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: >> >> Normally, the watchdog is disabled when /dev/watchdog is closed, but if >> CONFIG_WATCHDOG_NOWAYOUT is defined, then it means that the watchdog should >> remain enabled. So we should keep it enabled if CONFIG_WATCHDOG_NOWAYOUT >> is defined. >> >> Reported-by: Razvan Becheriu <razvan.becheriu@xxxxxxxxxxxxxx> >> Cc: Ferry Toth <fntoth@xxxxxxxxx> >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> >> --- >> drivers/watchdog/intel-mid_wdt.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c >> index 2cdbd37c700c..470213abfd3d 100644 >> --- a/drivers/watchdog/intel-mid_wdt.c >> +++ b/drivers/watchdog/intel-mid_wdt.c >> @@ -134,6 +134,7 @@ static int mid_wdt_probe(struct platform_device *pdev) >> wdt_dev->timeout = MID_WDT_DEFAULT_TIMEOUT; >> wdt_dev->parent = dev; >> >> + watchdog_set_nowayout(wdt_dev, WATCHDOG_NOWAYOUT); >> watchdog_set_drvdata(wdt_dev, dev); >> >> ret = devm_request_irq(dev, pdata->irq, mid_wdt_irq, >> -- >> 2.23.0 >>
