On Mon, Aug 12, 2019 at 01:08:58PM -0700, Andrey Smirnov wrote: > Bootloader code will ignore any attempts to write data to any flash > area outside of [ZIIRAVE_FIRM_FLASH_MEMORY_START; > ZIIRAVE_FIRM_FLASH_MEMORY_END]. Firmware update code already have an > appropriate check to skip those areas when validating updated > firmware. Firmware programming code, OTOH, does not and will > needlessly send no-op I2C traffic. Add an appropriate check to > __ziirave_firm_write_pkt() so as to save all of that wasted effort. > > While at it, normalize all of the address handling code to use full > 32-bit address in units of bytes and convert it to an appropriate > value only in places where that is necessary. > > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> > Cc: Chris Healy <cphealy@xxxxxxxxx> > Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > Cc: Rick Ramstetter <rick@xxxxxxxxxxxxxxx> > Cc: linux-watchdog@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>