Hi Mark, On Wed, Jul 31, 2019 at 09:17:13AM -0700, Mark Balantzyan wrote: > Hi Guenter, > > If it's not too much too ask, I also propose to rewrite alim1535_wdt to use > the watchdog subsystem as I believe we are making progress toward the > similar end in pc87413_wdt, as my evaluation ends in some weeks. > Please, no. We still have ways to go with that one driver, and we'll be stuck with a patch which I can't accept because of lack of testing. I (and you) really need to talk to your evaluators why they ask you to make those changes. This is highly inappropriate. The Linux kernel is not an feasible target for such an evaluation. This is setting you up for failure, and it is a waste of both your and my time. Are you really working for or on belalf of the Linux Foundation ? They should know better. And if Google is involved, I am embarassed for my employer. If they really want people to do work like this, they should also provide reviewers and coaching staff. They should most definitely not expect kernel maintainers to do it for them. Thanks, Guenter