On Tue, Jun 18, 2019 at 05:58:09PM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>
> Cc: Guenter Roeck <linux@xxxxxxxxxxxx>
> Cc: Florian Fainelli <f.fainelli@xxxxxxxxx>
> Cc: Ray Jui <rjui@xxxxxxxxxxxx>
> Cc: Scott Branden <sbranden@xxxxxxxxxxxx>
> Cc: bcm-kernel-feedback-list@xxxxxxxxxxxx
> Cc: linux-watchdog@xxxxxxxxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> ---
> drivers/watchdog/bcm_kona_wdt.c | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/watchdog/bcm_kona_wdt.c b/drivers/watchdog/bcm_kona_wdt.c
> index e2ad44816359..921291025680 100644
> --- a/drivers/watchdog/bcm_kona_wdt.c
> +++ b/drivers/watchdog/bcm_kona_wdt.c
> @@ -143,24 +143,18 @@ static void bcm_kona_wdt_debug_init(struct platform_device *pdev)
> wdt->debugfs = NULL;
>
> dir = debugfs_create_dir(BCM_KONA_WDT_NAME, NULL);
> - if (IS_ERR_OR_NULL(dir))
> - return;
>
> - if (debugfs_create_file("info", S_IFREG | S_IRUGO, dir, wdt,
> - &bcm_kona_fops))
> - wdt->debugfs = dir;
> - else
> - debugfs_remove_recursive(dir);
> + debugfs_create_file("info", S_IFREG | S_IRUGO, dir, wdt,
> + &bcm_kona_fops);
> + wdt->debugfs = dir;
> }
>
> static void bcm_kona_wdt_debug_exit(struct platform_device *pdev)
> {
> struct bcm_kona_wdt *wdt = platform_get_drvdata(pdev);
>
> - if (wdt && wdt->debugfs) {
> + if (wdt)
> debugfs_remove_recursive(wdt->debugfs);
> - wdt->debugfs = NULL;
> - }
> }
>
> #else
> --
> 2.22.0
>
