Re: [PATCH 11/46] watchdog: digicolor_wdt: drop warning after registering device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/19/19 1:32 AM, Wolfram Sang wrote:

Do you consider that not important/likely enough to be worth an error
message in the driver?

This can be discussed as a second step IMO.

I was looking at adding more error strings to the core but then wondered
if we really need error messages for e.g. IDA failures. And if so,
shouldn't those be in the IDA core. Do all IDA users want that?

(Sidenote: to the best of my knowledge, if memory allocation fails, it
will WARN you, so no need to print something in the driver.)


Correct. This is why it is discouraged to display an error message for
memory allocation failures (though some maintainers want it anyway,
but not me).

Guenter

So, I took a step back and saw that watchdog drivers mostly print
"registration failed", not more. Some printed the error code.

This series simplifies the current behaviour. It does not extend it. We
can do that on top of it.

Thanks for the comment!




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux