On Tue, Apr 23, 2019 at 11:48:33AM -0400, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > config NPCM7XX_WATCHDOG > bool "Nuvoton NPCM750 watchdog" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_platform_driver() uses the same init level priority as > builtin_platform_driver() the init ordering remains unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > was (or is now) contained at the top of the file in the comments. > > Cc: Avi Fishman <avifishman70@xxxxxxxxx> > Cc: Tomer Maimon <tmaimon77@xxxxxxxxx> > Cc: Tali Perry <tali.perry1@xxxxxxxxx> > Cc: Patrick Venture <venture@xxxxxxxxxx> > Cc: Nancy Yuen <yuenn@xxxxxxxxxx> > Cc: Benjamin Fair <benjaminfair@xxxxxxxxxx> > Cc: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx> > Cc: Guenter Roeck <linux@xxxxxxxxxxxx> > Cc: openbmc@xxxxxxxxxxxxxxxx > Cc: linux-watchdog@xxxxxxxxxxxxxxx > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> I'll send a different patch to make the driver tristate, to follow the example given by other drivers for the same chipset. Guenter
