Re: [PATCH 01/16] watchdog: refactor watchdog_init_timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello!

On 14.04.2019 13:26, Wolfram Sang wrote:

The function is not easy to read and has two problems: a) -EINVAL is
returned when the module parameter is invalid but the DT parameter is
OK, and b) for the module parameter, zero is a valid value but for DT it
is invalid.

Refactor the code to have a the same pattern of checks for the module
                            ^^^^^
   One article would be enough. :-)

parameter and DT. Further ones can be easily added in the future if the
need arises. The above mentioned problems are fixed, too.

Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
[...]

MBR, Sergei



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux