Re: [PATCH 01/16] watchdog: refactor watchdog_init_timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > The function is not easy to read and has two problems: a) -EINVAL is
> > returned when the module parameter is invalid but the DT parameter is
> > OK, and b) for the module parameter, zero is a valid value but for DT it
> > is invalid.
> > 
> 
> That was on purpose: A module parameter of 0 reflects that no module parameter
> was provided, which is not an error. An explicit DT property with value 0 _is_
> an error and does not make sense. "use the default", in the DT case, can and
> should be expressed by providing no property, not by providing a property with
> value 0.

OK, I can fix the code to do that as before. And add some documentation
to describe that. Please let me know if it is documented already and I
just missed it.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux