On Wed, 2019-04-10 at 09:27 -0700, Guenter Roeck wrote: > Introduce local variable 'struct device *dev' and use it instead of > dereferencing it repeatedly. > > The conversion was done automatically with coccinelle using the > following semantic patches. The semantic patches and the scripts > used to generate this commit log are available at > https://github.com/groeck/coccinelle-patches Interesting collection. It would be useful to specify which particular script generated or enabled this patch. Just scanning briefly, it might have been this one: https://github.com/groeck/coccinelle-patches/blob/master/common/deref.cocci But it looks like some manual bit might have been required too. And trivially: > diff --git a/drivers/watchdog/mt7621_wdt.c b/drivers/watchdog/mt7621_wdt.c [] > @@ -133,18 +133,19 @@ static struct watchdog_device mt7621_wdt_dev = { [] > watchdog_init_timeout(&mt7621_wdt_dev, mt7621_wdt_dev.max_timeout, > - &pdev->dev); > + dev); This could be on one line.