On Tue, 9 Apr 2019, at 10:33, Guenter Roeck wrote: > Hi Andrew, > > On 4/8/19 5:37 PM, Andrew Jeffery wrote: > > > > > > On Tue, 9 Apr 2019, at 05:09, Guenter Roeck wrote: > >> Introduce local variable 'struct device *dev' and use it instead of > >> dereferencing it repeatedly. > >> > >> The conversion was done automatically with coccinelle using the > >> following semantic patches. The semantic patches and the scripts > >> used to generate this commit log are available at > >> https://github.com/groeck/coccinelle-patches > >> > >> Cc: Joel Stanley <joel@xxxxxxxxx> > >> Cc: Andrew Jeffery <andrew@xxxxxxxx> > >> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> > >> --- > >> drivers/watchdog/aspeed_wdt.c | 21 +++++++++++---------- > >> 1 file changed, 11 insertions(+), 10 deletions(-) > >> > >> diff --git a/drivers/watchdog/aspeed_wdt.c b/drivers/watchdog/aspeed_wdt.c > >> index f09333fd54b4..34117745c65f 100644 > >> --- a/drivers/watchdog/aspeed_wdt.c > >> +++ b/drivers/watchdog/aspeed_wdt.c > >> @@ -187,6 +187,7 @@ static const struct watchdog_info aspeed_wdt_info = { > >> > >> static int aspeed_wdt_probe(struct platform_device *pdev) > >> { > >> + struct device *dev = &pdev->dev; > >> const struct aspeed_wdt_config *config; > >> const struct of_device_id *ofdid; > >> struct aspeed_wdt *wdt; > >> @@ -196,7 +197,7 @@ static int aspeed_wdt_probe(struct platform_device *pdev) > >> u32 status; > >> int ret; > >> > >> - wdt = devm_kzalloc(&pdev->dev, sizeof(*wdt), GFP_KERNEL); > >> + wdt = devm_kzalloc(dev, sizeof(*wdt), GFP_KERNEL); > >> if (!wdt) > >> return -ENOMEM; > > > > Looks like it's missed this one somehow? > > > > wdt->base = devm_ioremap_resource(&pdev->dev, res); > > > > Otherwise, > > > > Reviewed-by: Andrew Jeffery <andrew@xxxxxxxx> > > > > Assuming you mean the conversion to use devm_platform_ioremap_resource(), > I had this already addressed with a single patch for all watchdog drivers. > > https://patchwork.kernel.org/patch/10882207/ > > Sorry, I didn't Cc: you on that one - I limited the number of Cc:s to > avoid being > tagged as spammer. That's the piece I was missing. Thanks! Andrew
