On Tue, Dec 18, 2018 at 03:42:26PM -0800, Guenter Roeck wrote: > On Tue, Dec 18, 2018 at 05:34:41PM +0100, Andrew Lunn wrote: > > Some TQ-Systems ComExpress modules have an IO controller with a > > watchdog timer. > > > > Signed-off-by: Andrew Lunn <andrew@xxxxxxx> > > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> > > Nitpicks: > - SPDX license and MODULE_LICENSE mismatch > Maybe GPLv2 for both ? > - Signed-off-by: and MODULE_AUTHOR mismatch > Given the changes you have made, it might make sense > to mention "Based on out-of-tree driver from ..." > in the header and make yourself the module author. > Just a thought. > > Not sure if this warrants a resubmit. Your call. Hi Guenter I will probably respin, to fix the license at least. I've got a few similar issues in the Ethernet PHY subsystem i'm wondering what to do with, i don't really want to add another... Thanks Andrew
