Re: [PATCH v7 2/5] watchdog: da9063: Fix setting HW_RUNNING indication during wdt_start

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/24/2018 12:56 AM, Marco Felsch wrote:
Inform the watchdog framework that the watchog is running. Each driver
have to set this bit because the watchdog core framework only clears
this bit.


This should only be necessary if the stop function does not stop the watchdog.
Guess you need it because you call watchdog_hw_running() instead of
watchdog_active() in the next patch, but the context, description, and use
is not correct.

Guenter

Fixes: 5e9c16e37608 ("watchdog: Add DA9063 PMIC watchdog driver.")
Signed-off-by: Marco Felsch <m.felsch@xxxxxxxxxxxxxx>
---
  drivers/watchdog/da9063_wdt.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/watchdog/da9063_wdt.c b/drivers/watchdog/da9063_wdt.c
index c1216e61e64e..1b0ccadbc248 100644
--- a/drivers/watchdog/da9063_wdt.c
+++ b/drivers/watchdog/da9063_wdt.c
@@ -86,6 +86,8 @@ static int da9063_wdt_start(struct watchdog_device *wdd)
  		dev_err(da9063->dev, "Watchdog failed to start (err = %d)\n",
  			ret);
+ set_bit(WDOG_HW_RUNNING, &wdd->status);
+
  	return ret;
  }

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux