Re: [PATCH v2] watchdog: da9063: Fix setting/changing timeout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/16/2018 02:01 AM, Marco Felsch wrote:
Hi Steve and Guenter,

On Wed, May 16, 2018 at 07:35:13AM +0000, Steve Twiss wrote:
On 15 May 2018 19:44, Guenter Roeck wrote,

Subject: Re: [PATCH v2] watchdog: da9063: Fix setting/changing timeout

On Wed, May 09, 2018 at 04:10:15PM +0200, Marco Felsch wrote:
Hi Steve,


That would be great looking forward to hear from you. I will prepare a v3 if it is.

Any updates ?

Guenter
Hi Guenter and Marco,

Thank you for your patience.
The best advice I can give at the moment is:

Please follow what has been done in the DA9062 and DA9053 device drivers.
https://elixir.bootlin.com/linux/latest/source/drivers/watchdog/da9062_wdt.c#L90
https://elixir.bootlin.com/linux/latest/source/drivers/watchdog/da9052_wdt.c#L76

In these cases:
"setting TWDSCALE to zero for at least 150 us before writing the new value"
Okay. I tested it without a delay and saw no issues but I will add the
delay to be on the safe side.
Is that okay for you Guenter?

Yes. Better safe than sorry.

Thanks,
Guenter

There will be a longer answer, but that must wait until the formal datasheets have
been clarified by the hardware engineers.

Regards,
Steve

Regards,
Marco


--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux