On Mon, May 07, 2018 at 03:40:57PM +0200, John Crispin wrote: > > > On 07/05/18 15:34, Guenter Roeck wrote: > >On 05/07/2018 06:16 AM, John Crispin wrote: > >>If the userland tries to set a timeout higher than the max_timeout, > >>then we should fallback to max_timeout. > >> > > > >We don't do that for drivers using the watchdog core, so we should not > >do it here either for consistency. > > > >Guenter > > Hi, > thanks for the quick feedback. I'll mark the patch as "rejected by upstream > due to subsystem consistency" inside OpenWrt. Note that I am not completely opposed to the idea, but it should go through the watchdog core. You could convert the driver to use it, and then make the case that the subsystem should report <min, max> to userspace, relax set_timeout to adjust the requested timeout to [min,max] instead of letting userspace guess it, or both. Plus, of course, submit patches to actually implement and document the necessary changes. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
