On 14.8.2017 16:47, Guenter Roeck wrote: > On Fri, Aug 04, 2017 at 09:39:16AM +0200, Michal Simek wrote: >> Give read access to module parameters to all and write access to root. >> This change also improves driver error path testing. >> >> Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx> > > Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> > >> --- >> >> Please let me know what you think - I can use macros from stat.h if >> required >> > You mean instead of 0644 ? That is discouraged nowadays. yep and good. Thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html