On Mon, Aug 14, 2017 at 5:08 AM, Andrew Jeffery <andrew@xxxxxxxx> wrote: > There are two series on the lists expanding driver support for the Aspeed > watchdog, one from Chris Bostic and another from myself: > > 1. [PATCH v5 0/2] Add ASPEED watchdog device tree properties: > > https://lkml.org/lkml/2017/7/17/777 Looks all right. The SoC vs whole chip reset signal big is an Aspeed-specific extension AFAICT. > > 2. [PATCH 0/2] watchdog: aspeed: External reset signal properties: > > https://www.spinics.net/lists/kernel/msg2570666.html The external reset exists also in the Faraday FTWDT010 block, in the same bit. (No coincidence...) but neither the Gemini or the MOXA ART is using it as far as I know. > I don't have the datasheets for either the Moxa or Faraday SoCs, so I can't > assess how the support I've added for the external pulse properties on Aspeed > hardware impacts/is impacted by the merge. It's no big deal, I can rewrite the patches in the end of the series on top of that stuff also adding this functionality. > Chris' changes on the otherhand look > like they could be generalised. At least, the vendor prefix on the devicetree > properties he defined could perhaps be changed from aspeed to faraday. The "aspeed,reset-type" is fine since it is Aspeed-only. External reset is part of the Faraday IP block so it should be "faraday,external-reset-signal" or so. I will try to see if I can find the patches and comment directly. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
