On Sat, Jul 22, 2017 at 01:04:33PM -0300, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@xxxxxxx> > > platform_get_resource() may fail, so we should better check its > return value and propagate an error in case it fails. > > This avoids a NULL pointer dereference a bit later in the code. > > Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxx> Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx> > --- > drivers/watchdog/qcom-wdt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c > index 4f47b5e..7809713 100644 > --- a/drivers/watchdog/qcom-wdt.c > +++ b/drivers/watchdog/qcom-wdt.c > @@ -162,6 +162,8 @@ static int qcom_wdt_probe(struct platform_device *pdev) > return -ENOMEM; > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + if (!res) > + return -ENOMEM; > > /* We use CPU0's DGT for the watchdog */ > if (of_property_read_u32(np, "cpu-offset", &percpu_offset)) > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
