Re: [PATCH 1/5] watchdog: renesas_wdt: avoid (theoretical) type overflow

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/18/2017 12:21 AM, Wolfram Sang wrote:
-       unsigned long rate;
-       unsigned int clks_per_sec;
+       unsigned long rate, clks_per_sec;

If you make this change, you should also update rwdt_priv.clks_per_sec
(yes I know it's removed in a later patch in this series).

Right. I will change but also wait a bit for more comments.


I for my part don't have any. Feel free to add

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

to the series when you resend.

Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux