RE: [PATCH 1/2] watchdog: uniphier: add UniPhier watchdog driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yamada-san,

> > a/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> > b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> > new file mode 100644
> > index 0000000..a59d1ba
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> > @@ -0,0 +1,20 @@
> > +UniPhier watchdog timer controller
> > +
> > +This UniPhier watchdog timer controller must be under sysctrl compatible
> > node.
> > +
> > +Required properties:
> > +- compatible: should be "socionext,uniphier-wdt"
> > +
> > +Example:
> > +
> > +	sysctrl@61840000 {
> > +		compatible = "socionext,uniphier-ld11-sysctrl",
> > +			     "simple-mfd", "syscon";
> > +		reg = <0x61840000 0x4000>;
> > +
> > +		sys_wdt: watchdog {
> > +			compatible = "socionext,uniphier-wdt";
> > +		}
> > +
> > +		other nodes ...
> > +	};
> 
> 
> Next time, please include
> devicetree@xxxxxxxxxxxxxxx
> (and Rob) in your CC list for binding review.
> 
> I think scripts/get_maintainer.pl will do it correctly for you.
> 

OK. I will include to CC list in next v2 patch.

> 
> 
> > +#include <linux/delay.h>
> 
> Is this used?

It is unnecessary. I will remove it.

Thanks.

-----
Best Regards,
Keiji Hayashibara


--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux