Re: [PATCH] watchdog: zx2967: remove redundant dev_err call in zx2967_wdt_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 25, 2017 at 04:17:33PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/watchdog/zx2967_wdt.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/zx2967_wdt.c b/drivers/watchdog/zx2967_wdt.c
> index e290d5a..c982527 100644
> --- a/drivers/watchdog/zx2967_wdt.c
> +++ b/drivers/watchdog/zx2967_wdt.c
> @@ -211,10 +211,8 @@ static int zx2967_wdt_probe(struct platform_device *pdev)
>  
>  	base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	wdt->reg_base = devm_ioremap_resource(dev, base);
> -	if (IS_ERR(wdt->reg_base)) {
> -		dev_err(dev, "ioremap failed\n");
> +	if (IS_ERR(wdt->reg_base))
>  		return PTR_ERR(wdt->reg_base);
> -	}
>  
>  	zx2967_wdt_reset_sysctrl(dev);
>  
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux