On 04/16/2017 09:33 AM, Karim Eshapa wrote:
that's useful for the scheduler, power management unless the driver needs to delay in atomic context look at documentation/timers/timers-howto Signed-off-by: Karim Eshapa <karim.eshapa@xxxxxxxxx> --- drivers/watchdog/aspeed_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/aspeed_wdt.c b/drivers/watchdog/aspeed_wdt.c index 1c65258..17f06d1 100644 --- a/drivers/watchdog/aspeed_wdt.c +++ b/drivers/watchdog/aspeed_wdt.c @@ -115,7 +115,7 @@ static int aspeed_wdt_restart(struct watchdog_device *wdd, aspeed_wdt_enable(wdt, 128 * WDT_RATE_1MHZ / 1000); - mdelay(1000); + msleep(1000); return 0; }
Possibly, but how can you guarantee that the restart function is called with interrupts enabled ? Also, why would it be necessary or even useful for the scheduler to do anything while the system is in the process of restarting ? Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html