On Sat, Apr 1, 2017 at 2:27 AM, Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx> wrote: > This patch adds API's to read/write/update PMC GC registers. > PMC dependent devices like iTCO_WDT, Telemetry has requirement iTCO_wdt > to acces GCR registers. These API's can be used for this > purpose. > --- a/drivers/platform/x86/intel_pmc_ipc.c > +++ b/drivers/platform/x86/intel_pmc_ipc.c > +static inline int is_gcr_valid(u32 offset) Pointer to ipcdev should be a parameter to this function. > +{ > + if (!ipcdev.has_gcr_regs) > + return -EACCES; > + > + if (offset > PLAT_RESOURCE_GCR_SIZE) > + return -EINVAL; > + > + return 0; > +} > +/** > + * intel_pmc_gcr_update() - Update PMC GCR register bits > + * @offset: offset of GCR register from GCR address base > + * @mask: bit mask for update operation > + * @val: update value > + * > + * Updates the bits of given GCR register as specified by > + * mask and val -> * @mask and @val. You would need to refresh how to use kernel doc. > + * > + * Return: negative value on error or 0 on success. > + */ With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html