On Wed, Mar 08, 2017 at 05:11:10PM +0200, Andy Shevchenko wrote: > On Wed, 2017-03-08 at 06:21 -0800, Guenter Roeck wrote: > > Hi Andy, > > > > On 03/08/2017 03:10 AM, Andy Shevchenko wrote: > > > Firmware followed by bootloader leaves watchdog running. > > > > > > > Is that always the case ? > > Yes if no-one patched boot loader specifically to avoid this. > > > If not, does it hurt if the watchdog is pinged > > while not active ? > > > > Also, this assumes that its default timeout is in the default range > > configured by the driver, ie not (much) lower than 30 seconds. > > Correct. It is hard coded in SCU firmware (60 seconds IIRC). U-Boot for > now doesn't change it. > > > Not objecting, but it would help to have comments in the code > > explaining > > the context in some more detail. > > Last time you were not satisfied by the line which stops the running > watchdog [1]. I found a way how to keep it running gracefully, which I > proposed to do at that time (assuming boot loader doesn't stop it) [2]. > > I'm confused now what is preferable way to do the things? > The suggested patch is ok. I was just asking for additional comments, along the line of 1) the SCU firmware sets the timeout to 60s, the default timeout of 30s is therefore safe, and 2) that the watchdog is by default enabled in the SCU firmware (and, if appropriate, that it doesn't get a hiccup if it is pinged if it should have been disabled for some unspecified / unknown reason). Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
