On Tue, Feb 28, 2017 at 10:47:02PM +0100, Arnd Bergmann wrote: > On Tue, Feb 28, 2017 at 10:42 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > On Tue, Feb 28, 2017 at 10:01:17PM +0100, Arnd Bergmann wrote: > >> When the db8500 watchdog is enabled without the PRCMU, we get a lot of > >> warnings about duplicate or missing helper functions: > >> > >> In file included from drivers/watchdog/ux500_wdt.c:21:0: > >> include/linux/mfd/dbx500-prcmu.h:422:19: error: redefinition of 'prcmu_abb_read' > >> static inline int prcmu_abb_read(u8 slave, u8 reg, u8 *value, u8 size) > >> > >> This removes the duplicate function definitions and moves the helpers in > >> dbx500-prcmu outside of the #ifdef that hides them. > >> > > > > Is that appropriate ? Maybe we should just disable COMPILE_TEST > > for this driver instead. > > Or we could do both. The MFD driver was written to support this in principle, > it just hasn't worked in a long time. > Can you send me patches to disable COMPILE_TEST for this driver and for retu ? Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
