On 01/03/2017 03:50 PM, Andy Shevchenko wrote:
On Wed, Jan 4, 2017 at 1:48 AM, Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
On Wed, Jan 4, 2017 at 1:40 AM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
On Wed, Jan 04, 2017 at 12:39:59AM +0200, Andy Shevchenko wrote:
On Tue, Jan 3, 2017 at 4:39 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
Use pdev for struct platform_device, pcidev for struct pci_dev, and dev
for struct device variables to improve consistency.
Remove 'struct platform_device *dev;' from struct iTCO_wdt_private since
it was unused.
Would pci_dev work?
Sure, or maybe just 'pci'. Any preference ?
Just slightly prefer pci_dev over others (pcidev, pci), but do not
insist. Up to you.
Or even
struct device *dev;
...
struct pci_dev *pci_dev = to_pci_dev(dev);
'dev' would have to be a pointer to the parent device. If I consider using
dev_{info,err}, I'll need 'dev' in struct iTCO_wdt_private. I think I'll
stick with pci_dev.
Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
