Re: [PATCH v1] watchdog: imx2: fix hang-up on boot for i.MX21, i.MX27 and i.MX31 SoCs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Dec 24, 2016 at 11:00:59AM -0200, Fabio Estevam wrote:
> On Sat, Dec 10, 2016 at 11:06 PM, Vladimir Zapolskiy <vz@xxxxxxxxx> wrote:
> 
> >  static const struct of_device_id imx2_wdt_dt_ids[] = {
> > -       { .compatible = "fsl,imx21-wdt", },
> > +       { .compatible = "fsl,imx21-wdt", .data = IMX2_WDT_NO_WMCR },
> > +       { .compatible = "fsl,imx25-wdt",  },
> > +       { .compatible = "fsl,imx27-wdt", .data = IMX2_WDT_NO_WMCR },
> > +       { .compatible = "fsl,imx31-wdt", .data = IMX2_WDT_NO_WMCR },
> > +       { .compatible = "fsl,imx35-wdt",  },
> > +       { .compatible = "fsl,imx50-wdt",  },
> > +       { .compatible = "fsl,imx51-wdt",  },
> > +       { .compatible = "fsl,imx53-wdt",  },
> > +       { .compatible = "fsl,imx6q-wdt",  },
> > +       { .compatible = "fsl,imx6sl-wdt", },
> > +       { .compatible = "fsl,imx6sx-wdt", },
> > +       { .compatible = "fsl,imx6ul-wdt", },
> > +       { .compatible = "fsl,imx7d-wdt",  },
> > +       { .compatible = "fsl,vf610-wdt",  },
> >         { /* sentinel */ }
> 
> I understand this compatible list is not very nice, but in order to
> keep old dtb's working I don't see a better solution, so:
> 
> Reviewed-by: Fabio Estevam <fabio.estevam@xxxxxxx>

You can at least drop fsl,imx27-wdt and fsl,imx31-wdt which then fall
back correctly to fsl,imx21-wdt.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux